Skip to content

Docs/5625 v1 get query endpoint #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

MeelahMe
Copy link
Contributor

@MeelahMe MeelahMe commented Jul 30, 2025

Closes #6271
Closes #6272
Closes #5625

Adding GET & POST/query endpoint to cloud-serverless, dedicated, and cluster swagger

  • Rebased/mergeable

@MeelahMe MeelahMe requested review from jstirnaman and Copilot July 30, 2025 21:52
Copilot

This comment was marked as outdated.

@MeelahMe MeelahMe requested a review from sanderson July 30, 2025 21:53
@MeelahMe MeelahMe requested a review from Copilot July 30, 2025 22:37
Copilot

This comment was marked as outdated.

@MeelahMe MeelahMe added the API label Jul 31, 2025
@MeelahMe MeelahMe self-assigned this Jul 31, 2025
Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small, but important suggestions. Otherwise, looks good. Thanks for doing this!

@MeelahMe MeelahMe requested review from jstirnaman and removed request for sanderson August 1, 2025 20:57
Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these necessary?

Yes. InfluxQL is correct

@MeelahMe MeelahMe requested review from Copilot and jstirnaman August 5, 2025 20:43
Copilot

This comment was marked as outdated.

@MeelahMe MeelahMe removed the request for review from jstirnaman August 5, 2025 20:49
@MeelahMe MeelahMe requested a review from Copilot August 5, 2025 21:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GET and POST endpoint support for the /query endpoint to the InfluxDB v1 compatibility API documentation across three InfluxDB 3 products. The main purpose is to document both GET and POST query methods for the v1 HTTP API and update terminology from "bucket" to "database" for consistency.

Key changes:

  • Added comprehensive GET /query endpoint documentation with parameters, headers, and response schemas
  • Enhanced POST /query endpoint with JSON request body schema
  • Updated terminology from "bucket" to "database" throughout the documentation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
api-docs/influxdb3/clustered/v1-compatibility/swaggerV1Compat.yml Added GET query endpoint and enhanced POST endpoint with JSON schema; updated bucket→database terminology
api-docs/influxdb3/cloud-serverless/v1-compatibility/swaggerV1Compat.yml Added GET query endpoint and enhanced POST endpoint with JSON schema; updated bucket→database terminology
api-docs/influxdb3/cloud-dedicated/v1-compatibility/swaggerV1Compat.yml Added GET query endpoint and enhanced POST endpoint with JSON schema; updated bucket→database terminology

@MeelahMe MeelahMe requested a review from jstirnaman August 5, 2025 21:42
Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the v1-compat docs. My suggestions add explanation about

  • DBRP mapping and the differences between Cloud Serverless and Cloud Dedicated/Clustered. I realized we need to do a better job making this explicit for anyone looking to migrate from v1.
  • Use of "bucket" in Cloud Serverless. Sorry if my earlier comment misled you. Cloud Serverless still uses "bucket" to be consistent with Cloud v2 terminology.

Comment on lines +254 to +256
value: |
{"results":[{"statement_id":0,"series":[{"name":"mymeas","columns":["time","myfield","mytag"],"values":[["2016-05-19T18:37:55Z",90,"1"],["2016-05-19T18:37:56Z",90,"1"]],"partial":true}],"partial":true}]}
{"results":[{"statement_id":0,"series":[{"name":"mymeas","columns":["time","myfield","mytag"],"values":[["2016-05-19T18:37:57Z",90,"1"],["2016-05-19T18:37:58Z",90,"1"]]}]}]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For strict validation, this might need to be an object instead of string.

@jstirnaman jstirnaman self-requested a review August 6, 2025 16:51
Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this in the other specs as well, but that's a separate issue.

MeelahMe and others added 11 commits August 6, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants