fix(vale): propagate Google.Units=NO to product-specific Vale configs#6917
Merged
jstirnaman merged 4 commits intomasterfrom Mar 10, 2026
Merged
fix(vale): propagate Google.Units=NO to product-specific Vale configs#6917jstirnaman merged 4 commits intomasterfrom
jstirnaman merged 4 commits intomasterfrom
Conversation
…files Duration literals like 7d, 24h, 30d were being flagged as errors when running Vale with product-specific configs because those configs were missing Google.Units = NO. Also adds Vale.Terms = NO, write-good.TooWordy = NO, and TokenIgnores to match the root .vale.ini. Co-authored-by: jstirnaman <212227+jstirnaman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Vale linter rule for duration values
fix(vale): propagate Google.Units=NO to product-specific Vale configs
Mar 10, 2026
jstirnaman
approved these changes
Mar 10, 2026
github-actions
bot
added
product:v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product-specific
.vale.inifiles don't inherit from the root config — each is fully independent. PR #6798 addedGoogle.Units = NOto the root.vale.iniand introducedInfluxDataDocs.Units(byte units only) to allow InfluxDB duration literals, but didn't propagate those disables to product configs. Running Vale with any product-specific config still flagged7d,24h,30d, etc. as errors.Changes
5 product
.vale.inifiles (influxdb3/core,cloud-serverless,cloud-dedicated,clustered,influxdb/v2): added the same rule disables andTokenIgnoresalready present in the root config:Google.Units = NO— stops duration literals from being flaggedVale.Terms = NO— prevents URL/path false positiveswrite-good.TooWordy = NO— allows standard technical termsTokenIgnores— excludes URL paths and inline code globallyvale-lintingskill docs: added a callout warning that product configs must explicitly re-declare all disabled rules from the root config.Before (with
content/influxdb3/core/.vale.ini):After: 0 errors for duration literals across all product configs.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.