Skip to content

feat: use custom network dialer with kafka client#5606

Merged
mhilton merged 1 commit intomasterfrom
mhilton/kafka-network-dialer
Mar 12, 2026
Merged

feat: use custom network dialer with kafka client#5606
mhilton merged 1 commit intomasterfrom
mhilton/kafka-network-dialer

Conversation

@mhilton
Copy link
Copy Markdown
Contributor

@mhilton mhilton commented Mar 12, 2026

Initiate network connections to kafka using a custom dialer that supports IP address verification when configured.

Helps influxdata/idpe#19461

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

Initiate network connections to kafka using a custom dialer that supports
IP address verification when configured.
@mhilton mhilton requested a review from jdstrand March 12, 2026 11:35
@mhilton mhilton requested a review from a team as a code owner March 12, 2026 11:35
func newToKafkaProcedure(qs flux.OperationSpec, a plan.Administration) (plan.ProcedureSpec, error) {
spec, ok := qs.(*ToKafkaOpSpec)
if !ok && spec != nil {
if !ok {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mhilton mhilton merged commit 0228b18 into master Mar 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants