feat: use custom dialer for hdb database connections#5610
Merged
Conversation
lilic
reviewed
Mar 18, 2026
go.mod
Outdated
| go 1.24.0 | ||
|
|
||
| toolchain go1.24.2 | ||
| go 1.25.0 |
Member
There was a problem hiding this comment.
Why did we go with 1.25.0 but in other PR we used 1.25.7. I think 1.25.7 is the more correct as it has some security fixes?
Contributor
Author
There was a problem hiding this comment.
That value is based on the minimum version required for all the dependencies. In the end this will come out to the newest version of the set, but as there are a number of PRs running in parallel for each one it will be what it required by the changes in that PR.
lilic
approved these changes
Mar 18, 2026
When creating a new database connection to a SAP HANA database use a dialer derived from the provided dependencies.
8b4ff32 to
e00e2c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new database connection to a SAP HANA database use a dialer derived from the provided dependencies.
Closes influxdata/idpe#19468
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.