Skip to content

feat: use custom dialer for hdb database connections#5610

Merged
mhilton merged 1 commit intomasterfrom
mhilton/hdb-network-dialer
Mar 18, 2026
Merged

feat: use custom dialer for hdb database connections#5610
mhilton merged 1 commit intomasterfrom
mhilton/hdb-network-dialer

Conversation

@mhilton
Copy link
Contributor

@mhilton mhilton commented Mar 13, 2026

When creating a new database connection to a SAP HANA database use a dialer derived from the provided dependencies.

Closes influxdata/idpe#19468

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@mhilton mhilton requested a review from jdstrand March 13, 2026 12:03
@mhilton mhilton requested a review from a team as a code owner March 13, 2026 12:03
go.mod Outdated
go 1.24.0

toolchain go1.24.2
go 1.25.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we go with 1.25.0 but in other PR we used 1.25.7. I think 1.25.7 is the more correct as it has some security fixes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That value is based on the minimum version required for all the dependencies. In the end this will come out to the newest version of the set, but as there are a number of PRs running in parallel for each one it will be what it required by the changes in that PR.

When creating a new database connection to a SAP HANA database use a
dialer derived from the provided dependencies.
@mhilton mhilton force-pushed the mhilton/hdb-network-dialer branch from 8b4ff32 to e00e2c1 Compare March 18, 2026 15:54
@mhilton mhilton merged commit fc44665 into master Mar 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants