feat: add option for namespace selection for telegraf-operator webhook#729
Open
SHA65536 wants to merge 1 commit intoinfluxdata:masterfrom
Open
feat: add option for namespace selection for telegraf-operator webhook#729SHA65536 wants to merge 1 commit intoinfluxdata:masterfrom
SHA65536 wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
Author
|
@skartikey @eatondustin1 can you take a look? |
eatondustin1
previously approved these changes
Nov 24, 2025
Contributor
There was a problem hiding this comment.
@SHA65536 sorry for the delay, but this LGTM, thanks for the contribution 🙌
Contributor
|
@SHA65536
|
I'm dismissing my approval for now based on @skartikey 's feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option for the webhook to only match certain namespaces instead of all of them
In GKE they complain when you have a webhook that can intercept requests for system namespaces (kube-system, kube-node-lease) so I needed a way to adhere to their guidelines
I tested this on our company infra, seems fine
Thanks!