fix: important issues in InfluxDB3 Enterprise#756
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses critical and medium severity issues identified in a code review of the InfluxDB3 Enterprise Helm chart. The changes fix important bugs in license configuration, trace environment variables, object storage handling, and component-enabled checks across templates.
- Corrects the license file configuration to use a file path mount instead of embedding content in environment variables
- Fixes environment variable prefixes for traces (removes incorrect
INFLUXDB3_prefix) - Adds support for AWS credentials file as an alternative to access key/secret key authentication
- Adds conditional checks to prevent creating resources (Ingress, NetworkPolicy) for disabled components
- Removes dead code from helper templates and fixes YAML formatting issues
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
charts/influxdb3-enterprise/Chart.yaml |
Bumps chart version from 0.1.0 to 0.1.1 |
charts/influxdb3-enterprise/values.yaml |
Updates object storage comments, removes dead persistence.enabled fields, fixes PDB maxUnavailable, improves documentation |
charts/influxdb3-enterprise/templates/secret-object-storage.yaml |
Adds AWS credentials file secret creation and updates credential detection logic |
charts/influxdb3-enterprise/templates/processor-statefulset.yaml |
Adds initContainer for plugin installation, removes conditional wrapping of volume mounts and volumeClaimTemplates |
charts/influxdb3-enterprise/templates/networkpolicy.yaml |
Adds component-enabled checks to all NetworkPolicy resources |
charts/influxdb3-enterprise/templates/ingress-write.yaml |
Adds ingester.enabled check to prevent creating Ingress when component is disabled |
charts/influxdb3-enterprise/templates/ingress-query.yaml |
Adds querier.enabled check to prevent creating Ingress when component is disabled |
charts/influxdb3-enterprise/templates/configmap.yaml |
Fixes trace environment variable prefixes, adds object storage validation, adds AWS credentials file support |
charts/influxdb3-enterprise/templates/compactor-statefulset.yaml |
Removes empty conditional block |
charts/influxdb3-enterprise/templates/_helpers.tpl |
Removes unused helper functions, adds object storage type validation, fixes license file mounting with subPath |
charts/influxdb3-enterprise/templates/NOTES.txt |
Simplifies license configuration warning logic |
charts/influxdb3-enterprise/examples/values-dev.yaml |
Removes dead enabled fields from file storage configuration |
charts/influxdb3-enterprise/README.md |
Updates license.file parameter documentation to clarify --set-file usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charts/influxdb3-enterprise/templates/processor-statefulset.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jansimonb
left a comment
There was a problem hiding this comment.
LGTM, thanks! 👍 I had just minor comments.
charts/influxdb3-enterprise/templates/processor-statefulset.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Simon <63776254+jansimonb@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Jan Simon <63776254+jansimonb@users.noreply.github.com>
|
So when I commit reviewer's suggestion it dismisses the review. wth... |
|
no problem, this is set in project's settings :) |
Fixed most important (all critical and medium, and some low prio) issues per @jansimonb's review of PR #752:
_helpers.tpl