chore(ci): run launcher tests and remove unneeded --config-env option #27091
+104
−421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdstrand
force-pushed
the
jdstrand/misc-launcher-fixes
branch
from
4b2444e to
1e00384
Compare
* chore(ci): run launcher tests For now, just run on Linux amd64 since the launcher is cross-platform and OSX and Windows is expensive. If needed, we can run on other architectures and OSes at a later date. * chore(launcher): remove unneeded --config-env option
jdstrand
force-pushed
the
jdstrand/misc-launcher-fixes
branch
from
1e00384 to
143051b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(ci): run launcher tests
For now, just run on Linux amd64 since the launcher is cross-platform
and OSX and Windows is expensive. If needed, we can run on other
architectures and OSes at a later date.
chore(launcher): remove unneeded --config-env option
Due to differences in the
.circleci/config.ymlfile between Core and Enterprise, I could not do a clean cherry-pick from Enterprise and had to manually apply the changes to.circleci/config.ymlwhen backporting from Enterprise (the launcher and test updates were clean).