feat: add TLSConfigManager for managing TLS configuration #27100
+801
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidby-influx
requested changes
Jan 7, 2026
Contributor
davidby-influx
left a comment
davidby-influx
left a comment
There was a problem hiding this comment.
A few nits in the testing.
pkg/tlsconfig/configmanager_test.go
Outdated
| serverResult <- err | ||
| return | ||
| } | ||
| defer conn.Close() |
Member
Author
There was a problem hiding this comment.
Modified to send the Close error over the serverResult channel by joining it with the read error.
davidby-influx
approved these changes
Jan 7, 2026
Contributor
davidby-influx
left a comment
davidby-influx
left a comment
There was a problem hiding this comment.
LGTM. I missed the server-side error check in the first review...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.