feat: add request level timeout#287
Merged
crepererum merged 3 commits intoinfluxdata:mainfrom Feb 11, 2026
Merged
Conversation
crepererum
reviewed
Dec 11, 2025
|
|
||
| let mut response = rx.await.expect("Who closed this channel?!")?; | ||
| let mut response = if let Some(timeout) = self.timeout { | ||
| tokio::time::timeout(timeout, rx).await.map_err(|_| { |
Collaborator
There was a problem hiding this comment.
Could you add a code comment that captures #285 (comment) here? That would be great for future maintainers & contributors.
crepererum
approved these changes
Feb 11, 2026
Signed-off-by: WenyXu <wenymedia@gmail.com>
Signed-off-by: WenyXu <wenymedia@gmail.com>
Signed-off-by: WenyXu <wenymedia@gmail.com>
crepererum
force-pushed
the
feat/request-timeout
branch
from
acf8c54 to
ef5ffd3
Compare
Collaborator
|
Thank you for the PR and sorry for the review delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
This PR adds support for configuring a request-level timeout for Kafka broker communications. This is separate from the existing connection timeout and allows users to set a maximum duration for individual requests to complete.
ClientBuilder: Added a new
timeout()builder method to configure the request timeoutBrokerConnector: Propagates the timeout configuration to broker connections
Messenger: Implements the timeout logic using
tokio::time::timeoutwhen sending requestsConnectionHandler: Updated the trait interface to accept both
connection_timeoutandtimeoutparametersI've read the contributing section of the project CONTRIBUTING.md.
Signed CLA (if not already signed).