fix(inputs.upsd): Stop silently dropping mandatory variables from additional_fields#18367
Merged
mstrandboge merged 1 commit intoinfluxdata:masterfrom Feb 23, 2026
Merged
Conversation
…itional_fields When users configured additional_fields with patterns matching mandatory variables (e.g., battery.runtime), those fields were unconditionally skipped and never included in the output. Users only got the converted mandatory form (e.g., time_left_ns in nanoseconds) but never the raw field they explicitly requested (e.g., battery_runtime in seconds). The mandatoryVariableSet skip was a defensive guard to prevent duplicate fields, but it was redundant, mandatory variables are not in defaultFieldSet, so without a filter they already hit the else-continue path. Removing the skip lets the existing defaultFieldSet/filter/continue logic handle mandatory variables naturally, while preserving all existing behavior for default configs.
telegraf-tiger
bot
added
fix
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
added
the
ready for final review
mstrandboge
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additional_fieldssilently dropping variables that overlap with the mandatory variable set (e.g.,battery.runtime,device.model,device.serial,ups.firmware)mandatoryVariableSetguard, which unconditionally skipped mandatory variables before theadditional_fieldsfilter was evaluatedadditional_fieldsconfigured)Note
Users with
additional_fieldspatterns matching mandatory variables(e.g.,
battery.runtime,device.model) will see new raw fieldsin their output alongside the existing converted forms. For example,
battery_runtime=4020i(raw seconds) will now appear alongsidetime_left_ns=4020000000000i(nanoseconds). No existing fields areremoved or renamed.
Checklist
Related issues
resolves #18168