Skip to content

fix: sync conf files#7089

Closed
NguyenHoangSon96 wants to merge 2 commits intoinfluxdata:masterfrom
NguyenHoangSon96:fix/sync-conf-files
Closed

fix: sync conf files#7089
NguyenHoangSon96 wants to merge 2 commits intoinfluxdata:masterfrom
NguyenHoangSon96:fix/sync-conf-files

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Oct 28, 2025

  • This PR only syncs and fixes the "vsphere.conf" and "vsphere.md". So this additional PR will fix and sync contents for the rest of the ".conf" and ".md" files.
  • Looks like the instructions from "src/writeData/utils/README.md" are obsolete, so I modified the scripts in "updateTelegrafPlugins.mjs" and regenerated the "/telegraf/etc/telegraf.conf" file to make it work.
    updateTelegrafPlugins.txt

** More than 300+ files have been generated or edited, so I don't really know how to check, to be honest 😅, so if you guys think this PR is too much and unnecessary at the moment, please close it.

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Oct 28, 2025
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as ready for review October 28, 2025 04:02
@NguyenHoangSon96 NguyenHoangSon96 requested review from a team as code owners October 28, 2025 04:02
@NguyenHoangSon96 NguyenHoangSon96 changed the title Fix/sync conf files fix: sync conf files Oct 28, 2025
Copy link
Contributor

@wdoconnell wdoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend closing this. This is far too many changes in a single PR to be validated.

@philjb
Copy link
Contributor

philjb commented Nov 4, 2025

I recommend closing this. This is far too many changes in a single PR to be validated.

@wdoconnell -- the changes are programmatically generated from the telegraf repo.

How would you like the telegraf plugin confs to be updated? One conf to one pr? That would be a few hundred prs.

Either way, it's a tall task to have a human review each line of change. I think we need to lean on the programmatic generation with a couple spot checks (maybe a few programmatic verifications e.g. can telegraf read at startup all the conf files in this pr).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants