Closed
Conversation
wdoconnell
requested changes
Nov 4, 2025
Contributor
wdoconnell
left a comment
There was a problem hiding this comment.
I recommend closing this. This is far too many changes in a single PR to be validated.
Contributor
@wdoconnell -- the changes are programmatically generated from the telegraf repo. How would you like the telegraf plugin confs to be updated? One conf to one pr? That would be a few hundred prs. Either way, it's a tall task to have a human review each line of change. I think we need to lean on the programmatic generation with a couple spot checks (maybe a few programmatic verifications e.g. can telegraf read at startup all the conf files in this pr). |
This was referenced Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateTelegrafPlugins.txt
** More than 300+ files have been generated or edited, so I don't really know how to check, to be honest 😅, so if you guys think this PR is too much and unnecessary at the moment, please close it.
Checklist
Authors and Reviewer(s), please verify the following: