fixes a nil pointer dereference crash and adds backward compatibility for proto import paths#298
Open
shrutipathak2 wants to merge 1 commit intoinfobloxopen:mainfrom
Open
Conversation
… for proto import paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a nil pointer dereference crash and adds backward compatibility for proto import paths.
Changes
1. Bug Fix: Nil Pointer Dereference in Plugin
Fixed crash that occurred when processing proto files with non-message field types (e.g., primitive types like
int32,string).Affected functions in
plugin/plugin.go:followsUpdateConventions()- Added nil checks at lines 3171 and 3189followsUpdateSetConventions()- Added nil check at line 3109Added symlinks to support both old and new proto import paths:
// Both paths now work
import "github.com/infobloxopen/protoc-gen-gorm/options/gorm.proto"; // old
import "github.com/infobloxopen/protoc-gen-gorm/proto/options/gorm.proto"; // new