Migrate tslint to eslint including prettier#156
Open
swuendri wants to merge 18 commits intoinfor-cloud:masterfrom
Open
Migrate tslint to eslint including prettier#156swuendri wants to merge 18 commits intoinfor-cloud:masterfrom
swuendri wants to merge 18 commits intoinfor-cloud:masterfrom
Conversation
Contributor
Author
|
@anhallbe, I know you have less time for this project. But I want to improve it step by step to benefit from the innovations in other projects (Typescript, Angular, ...). Would you review my suggested changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR all Angular projects are migrated from TSLint to ESLint. Additionally I introduced prettier to avoid ESLint rules regarding formatting (see https://prettier.io/docs/en/comparison.html).
Prettier and ESLint checks are now part of main GitHub workflow.