Skip to content

fix: remove header check in detect_misbehaviour #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayT106 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove header check in detect_misbehaviour #4414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions crates/relayer/src/foreign_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1657,16 +1657,6 @@ impl<DstChain: ChainHandle, SrcChain: ChainHandle> ForeignClient<DstChain, SrcCh
break;
}

// No header in events, cannot run misbehavior.
// May happen on chains running older SDKs (e.g., Akash)
if update_event.header.is_none() {
Copy link

@thomas-nguy thomas-nguy Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the check alone won’t fix the problem, since the header is still required by detect_misbehaviour to compare it with the client state header.

cosmos/ibc-go#5110

Following the comment, we should call the /header endpoint to retrieve the header instead of relying on the event data.

return Err(ForeignClientError::misbehaviour_exit(format!(
"could not extract header from update client event {:?} emitted by chain {}",
update_event,
self.dst_chain.id()
)));
}

// Check for misbehaviour according to the specific source chain type.
// In case of Tendermint client, this will also check the BFT time violation if
// a header for the event height cannot be retrieved from the witness.
Expand Down