refactor: replace lodash.isequal with node:util.isDeepStrictEqual, #1606 #1809

yazaldefilimone · 2025-11-14T15:18:25Z

I have read and I understand the Note on AI-assisted contributions
Changes manually tested locally and confirmed to work as described
(including screenshots is helpful)
Tests added for any new code
Documentation added for any new functionality
Entries added to the respective CHANGELOG.md for any new functionality

…formalsystems#1606

bugarela

Hey, thanks for taking this on and sorry for the late review!

CONTRIBUTING.md

bugarela · 2025-11-27T11:12:45Z

quint/package-lock.json

We should not delete this file, it is necessary for building Quint with nix

@yazaldefilimone can you add this file back please? We can't delete it.

bugarela · 2025-11-27T11:14:28Z

quint/src/util.ts

+ *
+ */
+export function isEqual<L, R>(left: L, right: R): boolean {
+  return isDeepStrictEqual(left, right)


Not sure if we need this indirection here through util - we could just replace the imports to import isDeepStrictEqual and then use it directly instead of isEqual everywhere. @erickpintor do you have some advice here?

I agree. It'd be simpler to just rely on node:util for equality everywhere.

@yazaldefilimone can we delete this now?

Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>

bugarela

Hi! Sorry, I don't get notified by commits so you need to mention me or re-request a review when you want me to take a look again. We just have two more small things and then are good to merge

bugarela · 2025-12-12T11:56:08Z

quint/src/util.ts

+ *
+ */
+export function isEqual<L, R>(left: L, right: R): boolean {
+  return isDeepStrictEqual(left, right)


@yazaldefilimone can we delete this now?

bugarela · 2025-12-12T11:56:26Z

quint/package-lock.json

@yazaldefilimone can you add this file back please? We can't delete it.

…ilimone/quint into refactor/replace-lodash-isequal

bugarela

Thank you!

bugarela · 2025-12-16T15:13:16Z

quint/src/effects/simplification.ts


-import isEqual from 'lodash.isequal'
-import { unreachable } from '../util'
+import { isEqual, unreachable } from '../util'


This is making us fail to compile

Suggested change

import { isEqual, unreachable } from '../util'

import { unreachable } from '../util'

And we also need to add an import for isDeepStrictEqual

@bugarela sorry... fix now.

…port, informalsystems#1606

Copilot

Pull request overview

This PR refactors the codebase to replace the external lodash.isequal package with Node.js's built-in node:util.isDeepStrictEqual function, reducing external dependencies.

Removes the lodash.isequal dependency from package.json and package-lock.json
Updates function calls from isEqual to isDeepStrictEqual across multiple files
Updates documentation in CONTRIBUTING.md to reflect the new equality comparison approach

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
quint/src/util.ts	Updates documentation comment example (contains error)
quint/src/types/substitutions.ts	Changes equality check in type substitution (missing import)
quint/src/runtime/impl/nondet.ts	Updates comparison in nondeterministic evaluation loop (missing import)
quint/src/effects/substitutions.ts	Changes equality check in effect substitution (missing import)
quint/src/effects/simplification.ts	Updates entity deduplication logic and import (incorrect import)
quint/src/effects/modeChecker.ts	Adds import and updates entity comparison calls
quint/src/effects/base.ts	Adds import and updates multiple entity unification comparisons
quint/package.json	Removes lodash.isequal dependency
quint/package-lock.json	Removes lodash.isequal from lockfile
CONTRIBUTING.md	Updates documentation with new equality function and code examples

Files not reviewed (1)

quint/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-16T16:07:26Z

quint/src/util.ts

 * ```
 * const result = findMap([1,2,3], (x) => x % 2 === 0 ? just(x) : none<int>())
- * lodash.isEqual(result, just(2))
+ * lodash.isDeepStrictEqual(result, just(2))


The documentation comment incorrectly refers to lodash.isDeepStrictEqual. Since lodash doesn't have an isDeepStrictEqual method, this should just be isDeepStrictEqual (from node:util). Additionally, util.ts needs to import and re-export isDeepStrictEqual from node:util so that simplification.ts can import it from this module.

Copilot · 2025-12-16T16:07:26Z

quint/src/effects/simplification.ts

 */

-import isEqual from 'lodash.isequal'
 import { unreachable } from '../util'


The import statement references isEqual from '../util', but this file doesn't export isEqual. The util.ts file needs to import isDeepStrictEqual from 'node:util' and either export it directly or re-export it as isEqual. Additionally, the usage at line 102 should be isDeepStrictEqual, not isEqual.

Copilot · 2025-12-16T16:07:26Z

quint/src/types/substitutions.ts


  const result = singleApplication()
-  if (isEqual(result, t)) {
+  if (isDeepStrictEqual(result, t)) {


The function call uses isDeepStrictEqual but this function is not imported in this file. The import statement needs to be added: import { isDeepStrictEqual } from 'node:util'. Additionally, the existing import { isEqual } from 'lodash' import should be removed if it's no longer used elsewhere in the file.

Copilot · 2025-12-16T16:07:27Z

quint/src/runtime/impl/nondet.ts


        // Retry if condition is satisfied and we haven't exhausted all possible positions.
-      } while (shouldRetry && !isEqual(newPositions, originalPositions))
+      } while (shouldRetry && !isDeepStrictEqual(newPositions, originalPositions))


The function call uses isDeepStrictEqual but this function is not imported in this file. The import statement needs to be added: import { isDeepStrictEqual } from 'node:util'. Additionally, the existing import { isEqual } from 'lodash' import should be removed if it's no longer used elsewhere in the file.

Copilot · 2025-12-16T16:07:27Z

quint/src/effects/substitutions.ts


  return result.map(simplify).chain(r => {
-    if (!isEqual(r, e)) {
+    if (!isDeepStrictEqual(r, e)) {


The function call uses isDeepStrictEqual but this function is not imported in this file. The import statement needs to be added: import { isDeepStrictEqual } from 'node:util'. Additionally, the existing import { isEqual } from 'lodash' import should be removed if it's no longer used elsewhere in the file.

Copilot · 2025-12-16T16:07:27Z

quint/src/effects/simplification.ts

 */

-import isEqual from 'lodash.isequal'
 import { unreachable } from '../util'


Unused import isEqual.

yazaldefilimone and others added 3 commits November 14, 2025 17:15

refactor: replace lodash.isequal with node:util.isDeepStrictEqual, in…

c5d29aa

…formalsystems#1606

refactor: replace lodash.isequal with node:util.isDeepStrictEqual, in…

79b85f3

…formalsystems#1606

Merge branch 'main' into refactor/replace-lodash-isequal

fc6013e

bugarela reviewed Nov 27, 2025

View reviewed changes

yazaldefilimone and others added 7 commits November 28, 2025 23:26

Update CONTRIBUTING.md

31e9fbb

Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>

Update CONTRIBUTING.md

e707939

Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>

Update CONTRIBUTING.md

3332cc9

Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>

Update CONTRIBUTING.md

e7a05e7

Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>

refactor: remove function

970ccff

Merge branch 'informalsystems:main' into refactor/replace-lodash-isequal

097226c

update contributing.md

f875303

bugarela reviewed Dec 12, 2025

View reviewed changes

yazaldefilimone added 3 commits December 12, 2025 15:40

Merge branch 'informalsystems:main' into refactor/replace-lodash-isequal

4ef3173

Merge branch 'refactor/replace-lodash-isequal' of github.com:yazaldef…

8380912

…ilimone/quint into refactor/replace-lodash-isequal

refactor: remove function

53f5d6f

yazaldefilimone requested a review from bugarela December 12, 2025 13:48

bugarela approved these changes Dec 16, 2025

View reviewed changes

bugarela reviewed Dec 16, 2025

View reviewed changes

bugarela requested a review from Copilot December 16, 2025 15:21

Copilot started reviewing on behalf of bugarela December 16, 2025 15:22 View session

refactor: replace isEqual to isDeepStrictEqual and resolve missing im…

1ed7da8

…port, informalsystems#1606

Copilot AI reviewed Dec 16, 2025

View reviewed changes

	import { isEqual, unreachable } from '../util'
	import { unreachable } from '../util'

refactor: replace lodash.isequal with node:util.isDeepStrictEqual, #1606 #1809

Are you sure you want to change the base?

refactor: replace lodash.isequal with node:util.isDeepStrictEqual, #1606 #1809

Uh oh!

Conversation

yazaldefilimone commented Nov 14, 2025

Uh oh!

bugarela left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bugarela left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bugarela left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yazaldefilimone Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yazaldefilimone Dec 16, 2025 •

edited

Loading