fix(get): ensure getRunCommand does not clobber ExitError's msg#4
Merged
fix(get): ensure getRunCommand does not clobber ExitError's msg#4
Conversation
|
|
Basically, go-getter is masking the actual problem with incorrect handling of program exit codes: 1. They messed up err handling in get.go#L131-L140 [1] 2. They eventually get around to calling syscall.WaitStatus.ExitStatus [2] Which returns -1 if the WaitStatus was something other than exited So we revert to using the stdlib ProcessState.String() representation of this error. [1]: https://github.com/hashicorp/go-getter/blob/v1.7.8/get.go#L131-L140 [2]: https://cs.opensource.google/go/go/+/refs/tags/go1.24.4:src/syscall/syscall_linux.go;l=483-488
bazaah
force-pushed
the
fix/no-clobber-exit-err
branch
from
80fa662 to
79d18d3
Compare
aliscott
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically,
go-getter is masking the actual problem with incorrect handling of
program exit codes:
Which returns -1 if the WaitStatus was something other than exited
So we revert to using the stdlib ProcessState.String() representation
of this error.
Internal-Id:
ENG-119