Skip to content

Add support of new IAM driver#10

Merged
akremenetsky merged 1 commit intomasterfrom
feat/new-iam-support
Mar 23, 2026
Merged

Add support of new IAM driver#10
akremenetsky merged 1 commit intomasterfrom
feat/new-iam-support

Conversation

@akremenetsky
Copy link
Copy Markdown
Member

No description provided.

@akremenetsky akremenetsky self-assigned this Mar 23, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the service's authentication layer by integrating a new HTTP-based IAM driver. This change abstracts the underlying token processing logic, enhancing the system's flexibility and preparing it for diverse IAM implementations. The update improves the maintainability and future extensibility of the authentication mechanism.

Highlights

  • New IAM Driver Integration: Introduced a new HttpDriver from gcl_iam.drivers to handle Identity and Access Management (IAM) authentication, replacing the previous direct use of a token encryption algorithm.
  • Refactored WSGI Application Builder: The build_wsgi_application function was updated to directly accept an iam_engine_driver object, streamlining the authentication setup.
  • Middleware Configuration Update: The GenesisCoreAuthMiddleware now utilizes the new iam_engine_driver for authentication processing, removing the need for a separate token_algorithm parameter.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/build.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for a new IAM driver, refactoring the application startup to use an iam_driver object instead of a token_algorithm. The changes are logical and well-contained. I've provided a couple of suggestions to improve code clarity and maintainability: one regarding an unused import and another about using keyword arguments for better readability when instantiating the new driver.

@akremenetsky akremenetsky force-pushed the feat/new-iam-support branch 2 times, most recently from 7fcfe60 to 71c0ec8 Compare March 23, 2026 16:06
@akremenetsky akremenetsky force-pushed the feat/new-iam-support branch from 71c0ec8 to efef158 Compare March 23, 2026 16:09
Signed-off-by: Anton Kremenetsky <anton.kremenetsky@gmail.com>
@akremenetsky akremenetsky force-pushed the feat/new-iam-support branch from efef158 to c86c259 Compare March 23, 2026 16:11
@akremenetsky akremenetsky merged commit f2c1cff into master Mar 23, 2026
17 checks passed
@akremenetsky akremenetsky deleted the feat/new-iam-support branch March 23, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants