Fix ClassCastException in SensoryEventResponseHandler#1931
Merged
Conversation
fda86e6 to
c8eb47f
Compare
Tim-Linschoten
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
A
ClassCastExceptionwas thrown in production when theSensoryEventResponseHandlerreceived aTransitionFailedevent while awaiting a specific event via theNotifyOnEventreaction.Exception:
🔍 Cause
In the streaming method, the guard condition for
NotifyOnEventblindly castcache.headtoTransitionFiredwithout checking the actual type. When an interaction fails and aTransitionFailedevent is added to the cache, the subsequent check causes a crash.🛠️ Fix
Replaced the unsafe
asInstanceOfcast with pattern matching that safely handles bothTransitionFiredandTransitionFailedevents.Before (Unsafe)
After (Safe)
🧪 Testing
TransitionFailedevents are handled gracefully without crashing the handler.