Skip to content

[FIX] account_batch_payment_ux: allow paid payment state in batch#912

Open
cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
adhoc-dev:18.0-h-110999-cav
Open

[FIX] account_batch_payment_ux: allow paid payment state in batch#912
cav-adhoc wants to merge 1 commit intoingadhoc:18.0from
adhoc-dev:18.0-h-110999-cav

Conversation

@cav-adhoc
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 20, 2026 20:51
@roboadhoc
Copy link
Contributor

Pull request status dashboard

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Este PR intenta permitir que pagos en estado 'paid' puedan ser incluidos en lotes de pago (batch payments) mediante la extensión del método _valid_payment_states() del modelo account.batch.payment.

Changes:

  • Se añade el método _valid_payment_states() para extender los estados de pago válidos que pueden incluirse en un lote, agregando 'in_process' y 'paid' a la lista.

Comment on lines +46 to +47
super()._valid_payment_states()
return ['in_process', 'paid']
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La llamada a super()._valid_payment_states() en la línea 46 no captura ni usa su valor de retorno. Esto significa que cualquier estado válido definido en la clase padre se descarta completamente. Para extender correctamente los estados válidos, debes capturar el resultado del método padre y agregarlo a la lista de retorno. Considera cambiar la implementación para obtener los estados del padre y agregar los nuevos: states = super()._valid_payment_states() seguido de return states + ['paid'] si 'paid' no está ya incluido, o simplemente retornar la lista combinada apropiadamente.

Suggested change
super()._valid_payment_states()
return ['in_process', 'paid']
states = super()._valid_payment_states()
return list(dict.fromkeys(states + ['in_process', 'paid']))

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants