Skip to content

Comments

feat: use axum WS#26

Merged
prestwich merged 10 commits intomainfrom
prestwich/axum-ws
Mar 30, 2025
Merged

feat: use axum WS#26
prestwich merged 10 commits intomainfrom
prestwich/axum-ws

Conversation

@prestwich
Copy link
Member

@prestwich prestwich commented Mar 29, 2025

  • Wrap axum websocket in read/write stream impls
  • Add an axum handler that spawns pubsub tasks
  • Add a AxumWsCfg struct for state

@prestwich prestwich requested a review from Evalir March 29, 2025 12:41
@prestwich prestwich marked this pull request as ready for review March 29, 2025 13:12
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, much easier than what i expected

pub(crate) fn new(router: crate::Router<()>) -> Self {
Self {
root_tasks: Handle::current().into(),
root_tasks: Default::default(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caught me a little bug

@prestwich prestwich merged commit 05aa2b3 into main Mar 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants