Conversation
dylanlott
changed the title
|
Tested and confirmed that the roundtrip bin lands bundles of host and rollup transactions and notifies when they're confirmed. |
|
Rollup example isn't running though - need to diagnose but I suspect it's more contract permissions issues. |
|
Script has been updated and is confirmed working against Parmigiana test net. |
|
should this be marked as rfr? |
| @@ -77,19 +80,23 @@ fn get_example_order( | |||
| .with_deadline(Utc::now().timestamp() as u64 + (60 * 10)); | |||
|
|
|||
| if rollup { | |||
There was a problem hiding this comment.
i think we could simplify this a bit by getting the corresponding weth address and chain id before we construct the unsigned order, as that's the only thing that really changes
|
|
||
| /// Fill example [`SignedOrder`]s from the transaction cache. | ||
| #[instrument(skip_all, fields(target_order_signature = %target_order.permit.signature, target_order_owner = %target_order.permit.owner))] | ||
| #[instrument(skip_all, fields(target_order_signature = %target_order.permit().signature, target_order_owner = %target_order.permit().owner))] |
There was a problem hiding this comment.
orders since a bit ago now have a hash we can use as an identifier, so we can skip having all these fields
|
this repo is being archived in favor of the signet-orders crate in sdk right? |
|
yes it should be. IIRC the related ticket is now cancelled |
|
let's close PRs and archive this repo |
3 participants
chore: update for parmigiana
Closes ENG-1625.