Conversation
prestwich
commented
Mar 18, 2025
| } = block_env; | ||
|
|
||
| *number = self.bundle.state_block_number.as_number().map(U256::from).unwrap_or(*number); | ||
| *coinbase = self.bundle.coinbase.unwrap_or(*coinbase); |
Member
Author
There was a problem hiding this comment.
bugfix is here, coinbase was previously not set
Member
Author
There was a problem hiding this comment.
ya it's why i recommend destructuring in the implementation guide. easy to forget things
prestwich
commented
Mar 18, 2025
| impl SignetCallBundleResponse { | ||
| /// Accumulate a transaction result into the response. | ||
| pub fn accumulate_tx_result(&mut self, tx_result: EthCallBundleTransactionResult) { | ||
| fn accumulate_tx_result(&mut self, tx_result: EthCallBundleTransactionResult) { |
Member
Author
There was a problem hiding this comment.
using this instead of accumulate_tx would be incorrect
Evalir
approved these changes
Mar 18, 2025
| impl<I> BundleDriver<OrderDetector<I>> for SignetBundleDriver<'_> { | ||
| type Error<Db: Database + DatabaseCommit> = SignetBundleError<Db>; | ||
|
|
||
| #[instrument(skip_all, level = Level::DEBUG)] |
Member
There was a problem hiding this comment.
should we maybe add a custom target here as well?
Member
Author
There was a problem hiding this comment.
it gets the fn name as the target, which seems fine to me
Evalir
reviewed
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some cleanup and a bugfix