Skip to content

Adds journal code from node to evm#21

Closed
prestwich wants to merge 1 commit intomainfrom
prestwich/journal
Closed

Adds journal code from node to evm#21
prestwich wants to merge 1 commit intomainfrom
prestwich/journal

Conversation

@prestwich
Copy link
Copy Markdown
Member

@prestwich prestwich commented Mar 24, 2025

  • add the journal code, so we can trim it from the node
  • also adds a method to BlockResult to make a journal

@prestwich prestwich requested a review from a team as a code owner March 24, 2025 13:52
@prestwich prestwich self-assigned this Mar 24, 2025
@prestwich prestwich requested a review from Evalir March 24, 2025 13:52
Evalir
Evalir approved these changes Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. straight move from the node, but still looked at it again

@prestwich prestwich mentioned this pull request Mar 26, 2025
Merged
@prestwich
Copy link
Copy Markdown
Member Author

prestwich commented Mar 27, 2025

closing in favor of #24

@prestwich prestwich closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evalir Evalir Evalir approved these changes

Assignees

@prestwich prestwich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prestwich @Evalir