Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
force-pushed
the
prestwich/l1-lib
branch
from
81ecee3 to
319d8a7
Compare
prestwich
force-pushed
the
prestwich/clean-up
branch
from
3222713 to
c8c5f5d
Compare
prestwich
force-pushed
the
prestwich/l1-lib
branch
2 times, most recently
from
4cccf9a to
7333cc0
Compare
prestwich
force-pushed
the
prestwich/l1-lib
branch
from
5d13c01 to
6dd9ee5
Compare
Evalir
requested changes
Dec 8, 2025
Evalir
requested changes
Dec 9, 2025
src/l1/Signet.sol
Outdated
| bool is7702; | ||
| assembly { | ||
| let ptr := mload(0x40) | ||
| codecopy(ptr, 0, 0x20) |
Member
There was a problem hiding this comment.
i actually still think this is wrong. won't this just copy the actual SignetL1 (the delegation target) code instead of the EOA's code?
Member
Author
There was a problem hiding this comment.
hmmm, let's do extcodecopy(self, to be safe
prestwich
force-pushed
the
prestwich/l1-lib
branch
from
ff20708 to
7803309
Compare
prestwich
force-pushed
the
prestwich/clean-up
branch
from
c8c5f5d to
0a89189
Compare
prestwich
changed the base branch from
prestwich/clean-up
to
graphite-base/4
prestwich
force-pushed
the
graphite-base/4
branch
from
0a89189 to
59bf0b4
Compare
prestwich
force-pushed
the
prestwich/l1-lib
branch
from
7803309 to
a4c35f9
Compare
Merged
prestwich
force-pushed
the
prestwich/l1-lib
branch
from
a4c35f9 to
9dd29cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an L1 contract for Signet users