Skip to content

fix: resolve TODO by replacing panic with error return in UnbondTimestamp #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: resolve TODO by replacing panic with error return in UnbondTimestamp #360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98cc151
Update api.go
Himess Mar 7, 2025
1dc1341
Update api.go
Himess Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions x/move/keeper/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,15 @@ func (api GoApi) ShareToAmount(valBz []byte, metadata vmtypes.AccountAddress, sh
}

// UnbondTimestamp return staking unbond time
func (api GoApi) UnbondTimestamp() uint64 {
func (api GoApi) UnbondTimestamp() (uint64, error) {
unbondingTime, err := api.StakingKeeper.UnbondingTime(api.ctx)

// TODO - panic to error
if err != nil {
panic(err)
return 0, err
}

sdkCtx := sdk.UnwrapSDKContext(api.ctx)
return uint64(sdkCtx.BlockTime().Unix()) + uint64(unbondingTime.Seconds())
return uint64(sdkCtx.BlockTime().Unix()) + uint64(unbondingTime.Seconds()), nil
}

func (api GoApi) GetPrice(pairId string) ([]byte, uint64, uint64, error) {
Expand Down