Skip to content

Conversation

@dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Jan 5, 2026

This PR must be merged first to preserve the Git history of the deleted page files and the components that were moved into their respective locations in #1376 PR.

Deleted files:

  • agents-manage-ui/src/app/[tenantId]/projects/[projectId]/credentials/new/bearer/page.tsx
  • agents-manage-ui/src/app/[tenantId]/projects/[projectId]/traces/page.tsx
  • agents-manage-ui/src/app/[tenantId]/projects/[projectId]/traces/ai-calls/page.tsx
  • agents-manage-ui/src/app/[tenantId]/projects/[projectId]/traces/conversations/[conversationId]/page.tsx
  • agents-manage-ui/src/app/[tenantId]/projects/[projectId]/traces/tool-calls/page.tsx

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026

⚠️ No Changeset found

Latest commit: 4a54220

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
agents-manage-api Ready Ready Preview, Comment Jan 5, 2026 7:46pm
agents-manage-ui Error Error Jan 5, 2026 7:46pm
agents-run-api Ready Ready Preview, Comment Jan 5, 2026 7:46pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
agents-docs Skipped Skipped Jan 5, 2026 7:46pm

@claude
Copy link

claude bot commented Jan 5, 2026

Claude finished @dimaMachina's task —— View job


Code Review Complete

Todo List:

  • Read repository guidelines and understand codebase structure
  • Analyze the deleted file and understand its purpose
  • Search for references to the deleted file or similar patterns
  • Check if bearer credential functionality was moved elsewhere
  • Assess architectural impact and system design considerations
  • Provide comprehensive review feedback

Critical Issues ⚠️

1. Broken Navigation Route (High Priority)

The PR deletes /credentials/new/bearer/page.tsx but leaves a broken navigation link in src/app/[tenantId]/projects/[projectId]/credentials/new/page.tsx:57. Users clicking the "Bearer authentication" option will now encounter a 404 error.

Impact: This breaks the user flow for creating bearer credentials, making this feature completely inaccessible through the UI.

Required Fix: Either restore the deleted page or remove/redirect the navigation option.

2. Incomplete Feature Removal (High Priority)

The deletion appears to be part of removing bearer credential functionality, but the removal is incomplete:

  • Bearer authentication logic remains in NewCredentialForm (new-credential-form.tsx:46)
  • Bearer authentication detection exists in EditCredentialForm (edit-credential-form.tsx:47-49)
  • private-api-bearer provider still referenced throughout the codebase
  • The new credentials page still shows "Bearer authentication" as an option

Architectural Concern: Partial feature removal creates an inconsistent system state and technical debt.

Systemic Considerations

3. Missing Context (Medium Priority)

The PR title "wip" and description mentioning "move" don't align with the actual deletion. This suggests:

  • The change may be unintentional
  • Part of a larger refactoring that's incomplete
  • The file was meant to be moved elsewhere, not deleted

Recommendation: Clarify the intent - is this a temporary WIP deletion or permanent feature removal?

4. No Changeset (Low Priority)

The changeset-bot correctly flagged that this structural change needs a changeset entry. Removing user-facing functionality should be documented in the changelog.

Technical Assessment

Code Quality

The deleted file (bearer/page.tsx) followed established patterns:

  • ✅ Used proper TypeScript types
  • ✅ Followed Next.js App Router conventions
  • ✅ Implemented consistent breadcrumb structure
  • ✅ Used established component patterns (BodyTemplate, NewCredentialForm)

Architectural Alignment

The removal creates inconsistencies:

  • Navigation still references the deleted route
  • Backend credential creation logic remains unchanged
  • Provider icons and metadata still include bearer support
  • Form validation and submission logic expects bearer functionality

Recommendations

Immediate Actions Required

  1. Fix the broken route: Remove the bearer option from the credentials selection page OR restore the deleted page
  2. Clarify intent: Update PR description to explain whether this is feature removal or relocation
  3. Add changeset: Document the change for users

If Removing Bearer Functionality Permanently

  1. Remove bearer option from credentials selection UI
  2. Clean up bearer-specific code in forms and validation
  3. Remove private-api-bearer provider references
  4. Update documentation and user guides
  5. Consider migration path for existing bearer credentials

If This Was Accidental

  1. Restore the deleted file
  2. Ensure the intended "move" operation is completed properly

Severity: 🔴 Blocking - This PR breaks core functionality and should not be merged in its current state.

@vercel vercel bot temporarily deployed to Preview – agents-docs January 5, 2026 19:41 Inactive
@vercel vercel bot temporarily deployed to Preview – agents-docs January 5, 2026 19:41 Inactive
@vercel vercel bot temporarily deployed to Preview – agents-docs January 5, 2026 19:41 Inactive
@vercel vercel bot temporarily deployed to Preview – agents-docs January 5, 2026 19:43 Inactive
@vercel vercel bot temporarily deployed to Preview – agents-docs January 5, 2026 19:43 Inactive
@vercel vercel bot temporarily deployed to Preview – agents-docs January 5, 2026 19:44 Inactive
@vercel vercel bot temporarily deployed to Preview – agents-docs January 5, 2026 19:44 Inactive
@vercel
Copy link

vercel bot commented Jan 5, 2026

Deployment failed with the following error:

The Preview Deployment Suffix domain "preview.inkeep.com" doesn't point to Vercel nameservers. Learn more: https://vercel.link/3a1

@dimaMachina dimaMachina changed the title wip 1/2 automatically generate and render breadcrumbs in dashboard with Next.js /[tenantId]/@breadcrumbs/[...slug]/page.tsx parallel route Jan 5, 2026
@dimaMachina dimaMachina marked this pull request as ready for review January 5, 2026 19:53
Comment on lines -142 to -150
// Server-side pagination is now handled by the hook

// Refresh data when refreshKey changes
useEffect(() => {
if (refreshKey && refreshKey > 0) {
refresh();
refreshAggregateStats();
}
}, [refreshKey, refresh, refreshAggregateStats]);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this useEffect is never running since refreshKey is falsy (0) cc @shagun-singh-inkeep

const [refreshKey, _setRefreshKey] = useState(0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants