Skip to content

fix: preserve mock data when regenerating component render #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anubra266 merged 1 commit into from
Jan 5, 2026
Merged

fix: preserve mock data when regenerating component render #1380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions agents-manage-ui/src/components/data-components/render/component-render-generator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ export function ComponentRenderGenerator({

const generatePreview = async (instructions?: string) => {
setIsGenerating(true);
// Preserve existing mockData before clearing state (needed when regenerating with instructions)
const existingMockData = render?.mockData;
setRender(null);
setStreamingCode('');
setIsComplete(false);
Expand Down Expand Up @@ -111,9 +113,18 @@ export function ComponentRenderGenerator({
}

if (lastValidObject) {
setRender(lastValidObject);
// If regenerating with instructions and response doesn't include mockData (or has empty one),
// preserve the existing mockData from before the regeneration
const finalRender =
instructions &&
existingMockData &&
(!lastValidObject.mockData || Object.keys(lastValidObject.mockData).length === 0)
? { ...lastValidObject, mockData: existingMockData }
: lastValidObject;

setRender(finalRender);
setIsComplete(true);
onRenderChanged?.(lastValidObject);
onRenderChanged?.(finalRender);
toast.success('Render generated successfully');
} else {
throw new Error('No valid render generated');
Expand Down