Skip to content

Comments

(fix): Docs build + swapped icons#2211

Merged
Gaurav-Narayan-Varma merged 2 commits intomainfrom
change-demo-logo
Feb 20, 2026
Merged

(fix): Docs build + swapped icons#2211
Gaurav-Narayan-Varma merged 2 commits intomainfrom
change-demo-logo

Conversation

@Gaurav-Narayan-Varma
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2026

⚠️ No Changeset found

Latest commit: a6521cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agents-api Ready Ready Preview, Comment Feb 20, 2026 5:46am
agents-docs Ready Ready Preview, Comment Feb 20, 2026 5:46am
agents-manage-ui Ready Ready Preview, Comment Feb 20, 2026 5:46am

Request Review

Copy link
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

This PR swaps the icon for the "Get Demo" button in the documentation site sidebar from a Cloud icon to a Rocket icon (both from lucide-react).

Review Findings

No issues identified. This is a straightforward cosmetic change:

  • ✅ Import correctly updated (CloudRocket)
  • ✅ Usage correctly updated (<Cloud /><Rocket />)
  • ✅ No orphaned imports
  • ✅ No functional or behavioral changes

💭 Consider (0) 💭

None.

🕐 Pending Recommendations (0)

None.


✅ APPROVE

Summary: Clean icon swap with no issues. The Rocket icon is a nice upgrade for the "Get Demo" CTA — it conveys action and excitement better than a generic cloud. Ship it! 🚀

Discarded (0)

No findings to discard.

Reviewers (0)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
Direct review (orchestrator) 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: Sub-agent reviewers were skipped due to the trivial nature of this change (2-line icon swap). Direct orchestrator review was sufficient.

Copy link
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary

(0) Total Issues | Risk: Low

Re-review scope: Delta changes since last automated review (commit a6521cf66).

Delta Changes Reviewed

The delta consists of a single TypeScript type annotation fix in option-cards.tsx:

- const LuIcon: FC | undefined = luIcons[iconName.slice(2)];
+ const LuIcon: FC<{ className?: string }> | undefined = luIcons[iconName.slice(2)];

Assessment: ✅ Correct fix. The code passes { className: 'h-6 w-6' } to the Lucide icon component via createElement. Without the generic type parameter, FC defaults to FC<{}>, causing TypeScript to reject the className prop. The fix properly types the component to accept an optional className prop.

🔴❗ Critical (0) ❗🔴

None.

🟠⚠️ Major (0) 🟠⚠️

None.

🟡 Minor (0) 🟡

None.

💭 Consider (0) 💭

None.

🕐 Pending Recommendations (0)

None.


✅ APPROVE

Summary: Clean TypeScript fix that resolves a build issue. The type annotation is correct and minimal. Combined with the previously-reviewed icon swap, this PR is ready to ship! 🚀

Discarded (0)

No findings to discard.

Reviewers (1)
Reviewer Returned Main Findings Consider While You're Here Inline Comments Pending Recs Discarded
Direct review (orchestrator) 0 0 0 0 0 0 0
Total 0 0 0 0 0 0 0

Note: Sub-agent reviewers were skipped due to the trivial nature of this delta (1-line TypeScript type fix). Direct orchestrator review was sufficient.

@github-actions github-actions bot deleted a comment from claude bot Feb 20, 2026
@nick-inkeep nick-inkeep changed the title swapped icons (fix): Docs build + swapped icons Feb 20, 2026
@Gaurav-Narayan-Varma Gaurav-Narayan-Varma merged commit b68e5be into main Feb 20, 2026
9 of 11 checks passed
@Gaurav-Narayan-Varma Gaurav-Narayan-Varma deleted the change-demo-logo branch February 20, 2026 06:19
@github-actions
Copy link
Contributor

🔎💬 Inkeep AI search and chat service is syncing content for source 'Inkeep Agent Framework Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant