Add furthestTime #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/2geom/circle.cpp
Outdated
| } | ||
|
|
||
| Coord Circle::furthestTime(Point const &p) const { | ||
| return timeAt(p) + rad_from_deg(180); |
Contributor
There was a problem hiding this comment.
This can return anything between 0 and 3 * M_PI. It should return something within the range [0, 2 * M_PI) instead - the class Angle can be used for this.
Author
|
Thanks @tweenk for the review! I Just ask for help into the 2geom mailing list about the eliptical arc part. all the rest is done. Also I added two missing toys for furthest time |
tweenk
pushed a commit
that referenced
this pull request
Jun 19, 2018
tweenk
force-pushed
the
master
branch
2 times, most recently
from
599dbab to
ba767e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hackfest 2016