You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure what changed recently, but when a PR has no prerelease labels, the matrix filter produces [] and fail the job. This is an attempt to handle that.
Adds a has_packages output to the generate-prerelease-matrix job and gates the prereleases job behind an if condition that skips execution when no prerelease/* labels are present on the PR, preventing a matrix-with-empty-include failure.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The fix is correct. jq -n '$data | length > 0' emits the bare string true/false, and the if: ... == 'true' string comparison in GitHub Actions handles it properly. No issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not sure what changed recently, but when a PR has no
prereleaselabels, the matrix filter produces[]and fail the job. This is an attempt to handle that.Checklist
Related
Note
Adds a
has_packagesoutput to thegenerate-prerelease-matrixjob and gates theprereleasesjob behind anifcondition that skips execution when noprerelease/*labels are present on the PR, preventing a matrix-with-empty-include failure.Written by Mendral for commit 6b3163d.