AF-aware supernet calculation #387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow Servers to have various inet attribute types which configure behaviour of checking for IP address conflics. Type "loadbalancer" does not have an uniqueness check, type "network" only checks within the same servertype. Ensure that the uniqueness of IP address is checked symmetrically: "host" inet attribute type must not ensure its uniqueness against "network" and "loadbalancer", because they don't check against "host". For example it was possible to create a domain object for IP address of a VM, but it was impossible to create a VM once a domain existed. Improve the message shown to user in case of conflict.
Supernet is calculated only for intern_ip and expected to yield a single value for each Server. Most of our servers and loadbalancers are dual-stack, that is they have IPv4 and IPv6 addresses. The algorithm works fine for calculating route_network, as this is always a single object with IPv4 and IPv6 addresses. But it fails for provider_network: LB Pools might belong to a different provider_network for IPv4 and IPv6. For example IPv4 might be leased from datacenter, while IPv6 is from our own provider-independent prefix. Provide option to obey target address family when calculating a supernet. This allows for adding multiple supernet attributes e.g. provider_network_ipv4 and provider_network_ipv6.
Use code similar to _add_supernet_attribute_af() to calculate supernetworks for unspecified address family directly in query_materalizer. Remove get_supernet() from class Server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.