Remove intern_ip support from supernet calculation#392
Merged
Conversation
TuxPowered42
force-pushed
the
k_af_aware_supernet
branch
from
8dc8005 to
033bec8
Compare
TuxPowered42
changed the title
TuxPowered42
force-pushed
the
k_af_aware_supernet
branch
3 times, most recently
from
a160b1c to
9daca56
Compare
TuxPowered42
changed the title
lamaral
approved these changes
Mar 26, 2025
kofrezo
reviewed
Mar 26, 2025
Comment on lines
+201
to
+203
| net.server_id, net.hostname, net.intern_ip, net.servertype_id, | ||
| net_attr.inet_address_family, host_attr.inet_address_family, | ||
| host.server_id AS host_server_id, host_attr.attribute_id AS host_attr_name |
Contributor
There was a problem hiding this comment.
I find that more readable:
Suggested change
| net.server_id, net.hostname, net.intern_ip, net.servertype_id, | |
| net_attr.inet_address_family, host_attr.inet_address_family, | |
| host.server_id AS host_server_id, host_attr.attribute_id AS host_attr_name | |
| net.server_id, | |
| net.hostname, | |
| net.intern_ip, | |
| net.servertype_id, | |
| net_attr.inet_address_family, | |
| host_attr.inet_address_family, | |
| host.server_id AS host_server_id, | |
| host_attr.attribute_id AS host_attr_name |
TuxPowered42
force-pushed
the
k_af_aware_supernet
branch
2 times, most recently
from
55a135f to
b1d828b
Compare
kofrezo
approved these changes
Mar 26, 2025
This makes it possible to calculate AF-unaware supernets over any attribute.
Update tests to provide both AF-aware and AF-unaware supernets, name them the same way we use them at InnoGames for simplicity.
kofrezo
force-pushed
the
k_af_aware_supernet
branch
from
b1d828b to
7ae612e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to calculate AF-unaware supernets over any attribute. Update tests to provide both AF-aware and AF-unaware supernets, name them the same way we use them at InnoGames for simplicity.