NDCO-5968: Maintenance must not change force-kept node #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuxPowered42
force-pushed
the
ndco_5968
branch
6 times, most recently
from
1dcf3ed to
94845ff
Compare
This helps with developing by allowing to see testtool's decissions just as it was on production.
By definition it is supposed to mean that all checks of a LB Node have been ran at least once. However this requires finishing the dummy HealthCheck when running tests. Normal non-test operation would finish the HealthChecks too.
Notify LbPool::pool_logic() if its being called from ending a downtime. The LbNode ending the downtime must not be immediately considered for satisfying the min_nodes requirement, but only later, after more proper LbNodes, e.g. the ones force-kept before, are considered.
TuxPowered42
force-pushed
the
ndco_5968
branch
from
b95755f to
d78cf96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.