Skip to content

Conversation

@micha149
Copy link

@micha149 micha149 commented Dec 1, 2025

Summary

  • Added GitHub Actions workflow for automated deployment to GitHub Pages
  • Configured Vite base path for correct routing in subdirectory deployment
  • Implements secure deployment using OIDC authentication

Security Review ✅

Permissions (Principle of Least Privilege)

  • contents: read - Minimal read access only
  • pages: write - Only for Pages deployment
  • id-token: write - For secure OIDC authentication
  • ✅ No excessive permissions granted

Security Best Practices

  • ✅ Modern OIDC authentication (no long-lived tokens)
  • ✅ Official GitHub Actions only (trusted sources)
  • ✅ Deployment restricted to main branch only
  • ✅ No hardcoded secrets or API keys
  • ✅ Separate build and deploy jobs
  • ✅ Uses npm ci for reproducible builds

Configuration

  • Node.js v20 (LTS)
  • npm caching enabled
  • Concurrency control configured
  • Vite base path: /innoq-timer/

Changes

  • .github/workflows/deploy.yml - GitHub Actions workflow
  • vite.config.js - Added base path configuration

Test Plan

  • Verify workflow runs successfully on merge to main
  • Check deployment at https://innoq.github.io/innoq-timer/
  • Confirm application loads correctly with base path
  • Verify timer functionality works in deployed version

🤖 Generated with Claude Code

- Add base path configuration for GitHub Pages in vite.config.js
- Create GitHub Actions workflow for automatic deployment
- App will be available at https://innoq.github.io/innoq-timer/

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant