PHP 8.4 Deprecation: Implicitly marking parameter $target_screen as nullable is deprecated.

[Soean]

What kind of change does this PR introduce?
When I run PHP 8.4, I get a deprecation message. This PR fixes it.

What is the current behavior?

PHP Deprecated: MetaboxOrchestra\AdminNotices::add(): Implicitly marking parameter $target_screen as nullable is deprecated, the explicit nullable type must be used instead in /vendor/inpsyde/metabox-orchestra/src/AdminNotices.php on line 77

What is the new behavior (if this is a feature change)?
Adds explicit nullable type to target_screen which fixes the warning. Nullables is allowed since PHP 7.1, this package supports PHP >=7.2.

[Soean]

@Chrico How can we get this change in? 🙂

[Chrico]

@Chrico How can we get this change in? 🙂

Ui, PR from December 2024. 😶 I did not see that PR. Sorry about that! ☕

The PR looks good to me. Could you please merge master into your PR branch, so that we can also execute php-qa.yml for pull requests? I just added support for PHP 8.3 and 8.4 in the test matrix. :-) @Soean

[Chrico]

Thanks @Soean ! https://github.com/inpsyde/MetaboxOrchestra/releases/tag/0.5.0 :-)

[Soean]

Nice, that was quick. Thanks! 🙂

[Chrico]

Nice, that was quick. Thanks! 🙂

Considering that this PR is from December 2024...I guess the definition of "quick" varies 😬 Sorry again for keeping you waiting!