Open
Conversation
Collaborator
|
Hi Jon, can you update the PR description with a statement about what this script does and why we need it? Thanks! It will be helpful in the future. |
Collaborator
|
Is this connected to PR pushes yet? Or nightly runs? I was imagining that I'd see the test results run on this very branch as a proof that it works. |
to be reached then run various tests
Various thresholds will be exceeded with the current omnibus config, resulting in an error exit and follow-on tests not being run. Thresholds should be re-enabled once we have the relevant config enabled.
Collaborator
|
Hi Jon, I love that you added Makefile entries for the tests. I wonder if you plan to update the README or some other documentation to describe how to manually start the tests for main or other branches? Along with that, the PR description should tell me how to test this PR, which I do not see (or know how to do without thinking harder). Can you please update the "How to Test" section? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This workflow starts the omnibus process, bootstrapping from epoch 507 and using Mithril to sync, then monitors the process using the REST interface until the target epoch is reached. The current Cardano epoch is the default target epoch, but this can be changed by submitting a different epoch as the input to
Begin tests when the omnibus process reaches this epochwhen running the workflow manually.Once the target epoch is reached, integration tests are carried out on SPDD and DRDD, then the k6 framework is used to perform a smoke test.
The workflow is scheduled to start at 03:15 which should generally be after the completion of the working day for the team. It can also be manually triggered by team members on any branch to facilitate testing before merging.
Related Issue(s)
Relates to #637
How was this tested?
By selecting
Run omnibus bootstrap testin github actions, thenRun workflow'and choosing this branch, then using520as the input toBegin tests when the omnibus process reaches this epoch.Checklist
Impact / Side effects
Various aspects of the workflow and the tests are currently dependent on mainnet being the target network. Further work needs to be done to make this generic and applicable to other networks.
Reviewer notes / Areas to focus