fix: replace read_skip_rollbacks usage with read_with_rollbacks#801
Draft
whankinsiv wants to merge 2 commits intomainfrom
Draft
fix: replace read_skip_rollbacks usage with read_with_rollbacks#801whankinsiv wants to merge 2 commits intomainfrom
whankinsiv wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: William Hankins <william@sundae.fi>
…codebase Signed-off-by: William Hankins <william@sundae.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces all usage of
read_skip_rollbackswithread_with_rollbacks, preventing one cause of out of sync messages. The issue with our prior approach related toread_skip_rollbacksreading multiple messages within one pass on the state modules main run loop.Related Issue(s)
N/A
How was this tested?
drep_stateout of sync messages issue no longer occursChecklist
Impact / Side effects
Messages are now synchronized when handling a rollback within the same epoch.
Reviewer notes / Areas to focus
N/A