Skip to content

fix: replace read_skip_rollbacks usage with read_with_rollbacks#801

Draft
whankinsiv wants to merge 2 commits intomainfrom
whankinsiv/fix-out-of-sync
Draft

fix: replace read_skip_rollbacks usage with read_with_rollbacks#801
whankinsiv wants to merge 2 commits intomainfrom
whankinsiv/fix-out-of-sync

Conversation

@whankinsiv
Copy link
Collaborator

@whankinsiv whankinsiv commented Mar 20, 2026

Description

This PR replaces all usage of read_skip_rollbacks with read_with_rollbacks, preventing one cause of out of sync messages. The issue with our prior approach related to read_skip_rollbacks reading multiple messages within one pass on the state modules main run loop.

Related Issue(s)

N/A

How was this tested?

  • Verified that sync progresses as expected
  • Verified that drep_state out of sync messages issue no longer occurs

Checklist

  • My code builds and passes local tests
  • I added/updated tests for my changes, where applicable
  • I updated documentation (if applicable)
  • branch has ≤ 5 commits (honor system)
  • commit messages tell a coherent story
  • branch is up to date with main (rebased on main; fast-forward possible)
  • CI/CD passes on the merged-with-main result

Impact / Side effects

Messages are now synchronized when handling a rollback within the same epoch.

Reviewer notes / Areas to focus

N/A

Signed-off-by: William Hankins <william@sundae.fi>
@shd shd self-requested a review March 20, 2026 16:38
…codebase

Signed-off-by: William Hankins <william@sundae.fi>
@whankinsiv whankinsiv changed the title fix: use consume_sync for governance read in drep_state fix: replace read_skip_rollbacks usage with read_with_rollbacks Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant