Open
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds support for weighted decision points in AntiGen, allowing callers to influence which negatable generator is “zapped” based on per-point weight rather than uniform selection.
Changes:
- Extend
BiGen/DecisionPointplumbing to carry and apply aFloatweight, and switch zapping selection from “N-th decision point” to “cutoff weight”. - Add new public APIs
scaleWeightandreweighto adjust decision-point weights, plusreplicateMNormto normalize list weights. - Update benchmarks and changelog to reflect the new weighting feature.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/Test/AntiGen/Internal.hs |
Core implementation: weight propagation, weight-based zapping selection, new combinators (scaleWeight, reweigh). |
src/Test/AntiGen.hs |
Re-export new weighting APIs and add replicateMNorm. |
bench/Main.hs |
Update benchmark calls for zapAt’s new Float-based cutoff. |
CHANGELOG.md |
Note the new weighting-related additions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Soupstraw
force-pushed
the
jj/weighted-decision-points
branch
from
cdbfdac to
8379355
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Verifies that a generator with weight 0 is never zapped. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds weights to decision points. This makes it possible to fine-tune the probabilities of decision points to ensure a better test case distribution.
close #6