Skip to content

ADR-017: clarify IsShelleyBasedEra vs type families distinction#88

Draft
Copilot wants to merge 2 commits intojordan/adr-017-cardano-api-compatiblefrom
copilot/sub-pr-85-again
Draft

ADR-017: clarify IsShelleyBasedEra vs type families distinction#88
Copilot wants to merge 2 commits intojordan/adr-017-cardano-api-compatiblefrom
copilot/sub-pr-85-again

Conversation

Copy link

Copilot AI commented Mar 5, 2026

The type families section conflated two distinct mechanisms by implying IsShelleyBasedEra is part of the type-family dispatch, rather than a separate runtime constraint.

  • Separate the two concerns explicitly:
    • Type families → compile-time; determine the types of arguments callers must supply
    • IsShelleyBasedEra era → runtime constraint providing the era singleton (ShelleyBasedEra era) for dispatching to the correct ledger operations
  • Document caller requirements: polymorphic-era callers must include IsShelleyBasedEra era (or a stronger constraint implying it, e.g. IsBabbageBasedEra era) in their own type signatures

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: carbolymer <228866+carbolymer@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on ADR-017 regarding IsShelleyBasedEra ADR-017: clarify IsShelleyBasedEra vs type families distinction Mar 5, 2026
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant and does not bring a lot of new information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants