ADR-017: Add reference to ADR-009 module naming convention#89
Draft
Copilot wants to merge 2 commits intojordan/adr-017-cardano-api-compatiblefrom
Draft
ADR-017: Add reference to ADR-009 module naming convention#89Copilot wants to merge 2 commits intojordan/adr-017-cardano-api-compatiblefrom
Copilot wants to merge 2 commits intojordan/adr-017-cardano-api-compatiblefrom
Conversation
2 tasks
Co-authored-by: carbolymer <228866+carbolymer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on ADR-017: Include module naming convention reference
ADR-017: Add reference to ADR-009 module naming convention
Mar 5, 2026
carbolymer
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-017's Module Structure section lacked a reference to the established
cardano-apimodule naming convention.docs/ADR-017-Cardano-Api-Compatible.md: Added a link to ADR-009 in the Module Structure section, grounding theCardano.Api.Compatiblemodule family layout in the existing naming convention.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.