Conversation
johnalotoski
commented
Feb 13, 2026
johnalotoski
commented
- WIP
* Bumps blockfrost-platform -> 0.0.3-rc3 * Bumps cardano-address -> 4.0.2 * Bumps cardano-signer -> v1.34.0 * Bumps isd -> v0.6.1 * Bumps ogmios -> v6.14.0 * Bumps process-compose -> v1.90.0
There was a problem hiding this comment.
Pull request overview
This pull request contains routine maintenance updates for February 13, 2026, including dependency version bumps, code cleanup to remove unused parameters, and migration to current NixOS APIs.
Changes:
- Updated nixpkgs from nixos-25.05 to nixos-25.11, and nix from 2.29-maintenance to 2.33-maintenance
- Removed unused function parameters across multiple nixos modules (self, config, name) for cleaner code
- Migrated from deprecated system.extraSystemBuilderCmds to system.systemBuilderCommands
- Updated Python package build system to use modern pyproject-based approach
- Bumped versions for multiple Cardano ecosystem packages (mithril, blockfrost, cardano-addresses, ogmios, signer, isd, process-compose)
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/cardano-parts-project/flake/opentofu/cluster.nix | Removed unused self parameter from function signature |
| perSystem/packages/ssh-config-json.nix | Added pyproject and build-system configuration for modern Python packaging |
| flakeModules/process-compose.nix | Removed unused config and system parameters from mkPerSystemOption callback |
| flakeModules/pkgs.nix | Updated package versions for mithril-pre-release, blockfrost-platform, cardano-address, cardano-ogmios, cardano-signer, isd, and process-compose |
| flake/nixosModules/service-cardano-faucet.nix | Simplified moduleWithSystem callback by replacing unused config parameter with _ |
| flake/nixosModules/profile-pre-release.nix | Removed unused config parameter from moduleWithSystem callback |
| flake/nixosModules/profile-mithril-relay.nix | Removed unused flake parameter and name parameter from module definition |
| flake/nixosModules/profile-grafana-alloy.nix | Removed unused self parameter and changed runCommandNoCCLocal to runCommandLocal |
| flake/nixosModules/profile-common.nix | Added self parameter and system.systemBuilderCommands to write source info JSON |
| flake/nixosModules/profile-cardano-db-sync.nix | Simplified moduleWithSystem callback and removed unused name parameter |
| flake/nixosModules/profile-basic.nix | Migrated from deprecated system.extraSystemBuilderCmds to system.systemBuilderCommands |
| flake/nixosModules/profile-aws-ec2-ephemeral.nix | Removed unused flake parameter from module definition |
| flake.nix | Updated nixpkgs to 25.11, nix to 2.33-maintenance, and multiple cardano service dependencies to amick/add-dmq-node branch |
| flake.lock | Updated lock file entries for all dependency changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
flake.nix
Outdated
|
|
||
| cardano-submit-api-service-ng = { | ||
| url = "github:IntersectMBO/cardano-node/10.6.2"; | ||
| url = "github:IntersectMBO/cardano-node/amick/add-dmq-node"; |
There was a problem hiding this comment.
The cardano-submit-api-service-ng input is using a personal branch "amick/add-dmq-node" instead of a tagged release or main branch. This creates a dependency on an unstable, potentially temporary branch that may be rebased or deleted. Consider using a tagged release, a specific commit hash, or coordinating to merge this branch and update to a stable reference once available.
| url = "github:IntersectMBO/cardano-node/amick/add-dmq-node"; | |
| url = "github:IntersectMBO/cardano-node/7b9c2d4f5a6b7c8d9e0f1a2b3c4d5e6f7a8b9c0d"; |
flake.nix
Outdated
|
|
||
| cardano-tracer-service-ng = { | ||
| url = "github:IntersectMBO/cardano-node/10.6.2"; | ||
| url = "github:IntersectMBO/cardano-node/amick/add-dmq-node"; |
There was a problem hiding this comment.
The cardano-tracer-service-ng input is using a personal branch "amick/add-dmq-node" instead of a tagged release or main branch. This creates a dependency on an unstable, potentially temporary branch that may be rebased or deleted. Consider using a tagged release, a specific commit hash, or coordinating to merge this branch and update to a stable reference once available.
flake.nix
Outdated
|
|
||
| cardano-node-service-ng = { | ||
| url = "github:IntersectMBO/cardano-node/10.6.2"; | ||
| url = "github:IntersectMBO/cardano-node/amick/add-dmq-node"; |
There was a problem hiding this comment.
The cardano-node-service-ng input is using a personal branch "amick/add-dmq-node" instead of a tagged release or main branch. This creates a dependency on an unstable, potentially temporary branch that may be rebased or deleted. Consider using a tagged release, a specific commit hash, or coordinating to merge this branch and update to a stable reference once available.
