Skip to content

feat(rust): Update disable running benchmarks with nextest and llvm-cov #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2024
Merged

feat(rust): Update disable running benchmarks with nextest and llvm-cov #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
751b7c5
update cargo config.toml file
Mr-Leshiy Oct 25, 2024
96c1003
wip
Mr-Leshiy Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion earthly/rust/scripts/std_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def cargo_llvm_cov(

def cargo_bench(flags: str, verbose: bool = False) -> exec_manager.Result:
return exec_manager.cli_run(
"cargo bench " + f"{flags} ",
"cargo bench --all-targets --no-fail-fast" + f"{flags} ",
name="Benchmarks all run to completion check",
verbose=verbose,
)
Expand Down
4 changes: 2 additions & 2 deletions earthly/rust/stdcfgs/cargo_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ lint-vscode = "clippy --message-format=json-diagnostic-rendered-ansi --all-targe

docs = "doc --release --no-deps --document-private-items --bins --lib --examples"
# nightly docs build broken... when they are'nt we can enable these docs... --unit-graph --timings=html,json -Z unstable-options"
testunit = "nextest run --release --bins --lib --tests --benches --no-fail-fast -P ci"
testcov = "llvm-cov nextest --release --bins --lib --tests --benches --no-fail-fast -P ci"
testunit = "nextest run --release --bins --lib --tests --no-fail-fast -P ci"
testcov = "llvm-cov nextest --release --bins --lib --tests --no-fail-fast -P ci"
testdocs = "test --doc --release"

# Rust formatting, MUST be run with +nightly
Expand Down
4 changes: 2 additions & 2 deletions examples/rust/.cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ lint-vscode = "clippy --message-format=json-diagnostic-rendered-ansi --all-targe

docs = "doc --release --no-deps --document-private-items --bins --lib --examples"
# nightly docs build broken... when they are'nt we can enable these docs... --unit-graph --timings=html,json -Z unstable-options"
testunit = "nextest run --release --bins --lib --tests --benches --no-fail-fast -P ci"
testcov = "llvm-cov nextest --release --bins --lib --tests --benches --no-fail-fast -P ci"
testunit = "nextest run --release --bins --lib --tests --no-fail-fast -P ci"
testcov = "llvm-cov nextest --release --bins --lib --tests --no-fail-fast -P ci"
testdocs = "test --doc --release"

# Rust formatting, MUST be run with +nightly
Expand Down
5 changes: 0 additions & 5 deletions examples/rust/crates/foo/benches/benchmark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
//! Simple benchmark example
use criterion::{black_box, criterion_group, criterion_main, Criterion};

#[test]
fn test_fibonacci() {
assert_eq!(fibonacci(20), 6765);
}

/// fibonacci calculates the nth fibonacci number
fn fibonacci(n: u64) -> u64 {
match n {
Expand Down