Skip to content

feat(rust/immutable-ledger): Replace ULID to UUID v7 for immutable-ledger #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 19, 2024
Merged

feat(rust/immutable-ledger): Replace ULID to UUID v7 for immutable-ledger #117

merged 10 commits into from
Dec 19, 2024

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Dec 19, 2024

Description

Replaced ULID to UUID v7 for the immutable-ledger design specs and implementation.

@Mr-Leshiy Mr-Leshiy requested review from cong-or and stevenj December 19, 2024 10:30
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Dec 19, 2024
@Mr-Leshiy Mr-Leshiy self-assigned this Dec 19, 2024
@Mr-Leshiy Mr-Leshiy changed the title feat(rust/immutable-ledger): feat(rust/immutable-ledger): Replace ULID to UUID v7 for immutable-ledger Dec 19, 2024
stevenj
stevenj previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cong-or
cong-or previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 228/228}$ | ${\color{red}Fail: 0/228}$ |

@Mr-Leshiy Mr-Leshiy dismissed stale reviews from cong-or and stevenj via ad0f965 December 19, 2024 11:31
@Mr-Leshiy Mr-Leshiy requested a review from cong-or December 19, 2024 14:13
cong-or
cong-or approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mr-Leshiy Mr-Leshiy merged commit 433f3cb into main Dec 19, 2024
19 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/vote-repl-ulid branch December 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cong-or cong-or cong-or approved these changes

@stevenj stevenj stevenj left review comments

Assignees

@Mr-Leshiy Mr-Leshiy

Labels

review me PR is ready for review

Projects

Catalyst
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mr-Leshiy @stevenj @cong-or