Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Dec 29, 2024

@Mr-Leshiy Mr-Leshiy self-assigned this Dec 29, 2024
@Mr-Leshiy Mr-Leshiy added the do not merge yet PR is not ready to be merged yet label Dec 29, 2024
@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 228/228}$ | ${\color{red}Fail: 0/228}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Test Report | ${\color{lightgreen}Pass: 254/254}$ | ${\color{red}Fail: 0/254}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

@Mr-Leshiy Mr-Leshiy requested a review from bkioshn January 8, 2025 15:21
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documents look good from a high level perspective.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

Copy link
Contributor

@neil-iohk neil-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional issues identified with changes, as discussed some future improvements currently out of scope identified and I will add them for discussion and consideration.

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit cb475a6 into main Jan 9, 2025
2 checks passed
@stevenj stevenj deleted the feat/signed-object branch January 9, 2025 11:54
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Report | ${\color{lightgreen}Pass: 294/294}$ | ${\color{red}Fail: 0/294}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Update vote tx v2 and immutable ledger specs to make it compatible with catalyst signed doc format

6 participants