Skip to content

Conversation

@stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Jan 17, 2025

Description

  • The ProblemReport Clone implementation was updated to create a shallow copy that shares the state with the original instance.

Related Issue(s)

Closes #157.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 263/263}$ | ${\color{red}Fail: 0/263}$ |

@stanislav-tkach stanislav-tkach changed the title Make ProblemReport to perform a shallow copy on clone feat(rust/catalyst-types): Make ProblemReport to perform a shallow copy on clone Jan 17, 2025
@stanislav-tkach stanislav-tkach self-assigned this Jan 17, 2025
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 581121b into main Jan 20, 2025
22 of 31 checks passed
@stevenj stevenj deleted the problem-report-shallow-clone branch January 20, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

ProblemReport.clone() should perform a shallow copy

4 participants