Skip to content

Conversation

@stanislav-tkach
Copy link
Member

@stanislav-tkach stanislav-tkach commented Jan 21, 2025

Description

  • Added rc to the list of serde features for the catalyst-types crate.
  • Added a test for ProblemReport serialization.

Description of Changes

Serde provides Serialize/Deserialize implementations for Rc<T> and Arc<T> but it is hidden under the rc feature.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@stanislav-tkach
Copy link
Member Author

Alternatively I can manually add the Serialize implementation. This is a less invasive, but more verbose approach.

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 41c1446 into main Jan 22, 2025
31 checks passed
@stevenj stevenj deleted the enable-rc-feature-flag-for-serde-depencency-for-catalyst-types branch January 22, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants