Skip to content

fix(rust/signed-doc): Change types for brand_id, campaign_id and category_id meta fields. #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 28, 2025
Merged

fix(rust/signed-doc): Change types for brand_id, campaign_id and category_id meta fields. #181

merged 8 commits into from
Jan 28, 2025

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Jan 27, 2025

Description

Changed brand_id, campaign_id and category_id Catalyst Signed Document metadata fields from UUIDv4 to DocumentRef type.

Related Issue(s)

Part of input-output-hk/catalyst-voices#1689

@Mr-Leshiy Mr-Leshiy requested a review from stevenj January 27, 2025 11:18
@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) January 27, 2025 11:24
@Mr-Leshiy Mr-Leshiy disabled auto-merge January 27, 2025 11:24
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Jan 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

saibatizoku
saibatizoku approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@Mr-Leshiy Mr-Leshiy merged commit 94f7445 into main Jan 28, 2025
22 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/signed-doc-meta-fields branch January 28, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saibatizoku saibatizoku saibatizoku approved these changes

@stevenj stevenj Awaiting requested review from stevenj

Assignees

No one assigned

Labels

review me PR is ready for review

Projects

Catalyst
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mr-Leshiy @saibatizoku