Skip to content

feat(rust/signed-doc): Add signing and verification logic to Catalyst Signed Docs #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 3, 2025
Merged

feat(rust/signed-doc): Add signing and verification logic to Catalyst Signed Docs #185

merged 20 commits into from
Feb 3, 2025

Conversation

@saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Jan 28, 2025

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

Closes #162

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added the enhancement New feature or request label Jan 28, 2025
@saibatizoku saibatizoku self-assigned this Jan 28, 2025
@saibatizoku saibatizoku force-pushed the feat/doc-signing-logic branch from a612907 to 70440b5 Compare January 28, 2025 01:16
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

✅ Test Report | ${\color{lightgreen}Pass: 272/272}$ | ${\color{red}Fail: 0/272}$ |

@saibatizoku saibatizoku changed the title feat(rust/signed-doc): Add signing and verification logic to Catalyst Sigen feat(rust/signed-doc): Add signing and verification logic to Catalyst Signed Docs Jan 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

Mr-Leshiy
Mr-Leshiy reviewed Jan 30, 2025
View reviewed changes
@saibatizoku saibatizoku marked this pull request as ready for review January 31, 2025 03:21
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025

✅ Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

Mr-Leshiy
Mr-Leshiy previously approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2025

✅ Test Report | ${\color{lightgreen}Pass: 274/274}$ | ${\color{red}Fail: 0/274}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2025

✅ Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

@saibatizoku saibatizoku force-pushed the feat/doc-signing-logic branch from b82ec2a to a2af6f1 Compare February 3, 2025 00:03
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

Mr-Leshiy
Mr-Leshiy approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 4f6462a into main Feb 3, 2025
20 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/doc-signing-logic branch February 3, 2025 12:37
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

✅ Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

Assignees

@saibatizoku saibatizoku

Labels

enhancement New feature or request

Projects

Catalyst
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CatalystSignedDocument signing logic

3 participants

@saibatizoku @Mr-Leshiy