Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

Description

Updated ExtraFields::from_protected_header to return Option<Self> instead of unused Result.
Fixed issue with returning an invalid result when error_report argument passed with already predefined some error reports inside it.

@Mr-Leshiy Mr-Leshiy self-assigned this Feb 2, 2025
@Mr-Leshiy Mr-Leshiy requested review from bkioshn, saibatizoku and stevenj and removed request for bkioshn and saibatizoku February 2, 2025 16:49
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Feb 2, 2025
@Mr-Leshiy Mr-Leshiy changed the title fix(rust/catalyst-signed-doc): Fix ExtraFields::from_protected_header error return fix(rust/signed-doc): Fix ExtraFields::from_protected_header error return Feb 2, 2025
@Mr-Leshiy Mr-Leshiy requested a review from bkioshn February 3, 2025 08:13
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Report | ${\color{lightgreen}Pass: 273/273}$ | ${\color{red}Fail: 0/273}$ |

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) February 3, 2025 12:38
@Mr-Leshiy Mr-Leshiy merged commit 85d3e41 into main Feb 3, 2025
2 checks passed
@Mr-Leshiy Mr-Leshiy deleted the fix/extra-fields-build branch February 3, 2025 12:38
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants