Skip to content

Conversation

@saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Feb 3, 2025

Description

Use the catalyst-id and type for it in catalyst-libs, to parse and validate kid for signatures on a signed document.
Implement an authors() function on the document type, which returns a list of all authors (being short_id() versions of all kids. Implement an kids()function on the document type which returns a list of allkids()needed to validate the document. Expose a validate function which takes an algorithm identifier and public key which matches the algorithm, for eachkidreturned by thekids()` function. There is no need to partially validate, so if all public keys are not supplied then validation has failed.

The caller will extract the public key and algorithm from the RBAC registration.
Do not create a new set of types for these, use common types supported and exposed by the RBAC registration crate itself.

Related Issue(s)

Closes #161

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku self-assigned this Feb 3, 2025
@saibatizoku saibatizoku added the enhancement New feature or request label Feb 3, 2025
@saibatizoku saibatizoku changed the base branch from main to feat/doc-signing-logic February 3, 2025 00:44
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

@saibatizoku saibatizoku marked this pull request as ready for review February 3, 2025 05:22
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

stanislav-tkach
stanislav-tkach previously approved these changes Feb 3, 2025
Base automatically changed from feat/doc-signing-logic to main February 3, 2025 12:37
@Mr-Leshiy Mr-Leshiy dismissed stanislav-tkach’s stale review February 3, 2025 12:37

The base branch was changed.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Test Report | ${\color{lightgreen}Pass: 275/275}$ | ${\color{red}Fail: 0/275}$ |

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku enabled auto-merge (squash) February 4, 2025 14:18
@saibatizoku saibatizoku requested a review from Mr-Leshiy February 4, 2025 14:18
@saibatizoku saibatizoku merged commit ef5c92e into main Feb 4, 2025
2 checks passed
@saibatizoku saibatizoku deleted the feat/use-catalyst-id branch February 4, 2025 14:18
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Report | ${\color{lightgreen}Pass: 276/276}$ | ${\color{red}Fail: 0/276}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Update signed document deserializer to use catalyst-id as kid

4 participants